★ wanayoo — archive 1999 https://github.com/phpmyadmin/sql-parser/issues/310Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter accepts false syntax in view definitions #310

Open
aszenz opened this issue Aug 13, 2020 · 1 comment · May be fixed by #311
Open

Linter accepts false syntax in view definitions #310

aszenz opened this issue Aug 13, 2020 · 1 comment · May be fixed by #311
Labels

Comments

@aszenz
Copy link

@aszenz aszenz commented Aug 13, 2020 •

Thanks for this wonderful library.

It seems like the linter doesn't catch any syntax errors for the view definitions.

Running ./vendor/bin/lint-query --query "CREATE VIEW abc AS WRONG_SELECT a, b FROM a" gives back no parsing errors even though the syntax is clearly wrong.

Tested on the latest version 5.3, the older 4.1 version also had the same issue.

@williamdes williamdes added the bug label Aug 13, 2020
@williamdes
Copy link
Member

@williamdes williamdes commented Aug 13, 2020

Hi @aszenz
Thank you !

We are lacking contributors and time to fix issues this month on this library, if you feel like opening a pull-request to QA branch we will be glad to welcome your contribution :)

aszenz added a commit to aszenz/sql-parser that referenced this issue Aug 23, 2020
The view statement body was not being  validated, used existing
select statement to ensure that the view definition is correctly
linted.
Also updated generated parser tests in / out tests.
@aszenz aszenz linked a pull request that will close this issue Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.