★ wanayoo — archive 1999 https://github.com/phpredis/phpredis/issues/1Nouvelle recherche | Portail wanayoo
Skip to content

/ phpredis

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renameNx delivers false on success #1

Closed
tompro opened this issue Mar 28, 2011 · 6 comments
Closed

renameNx delivers false on success #1

tompro opened this issue Mar 28, 2011 · 6 comments
Labels
work in progress

Comments

@tompro
Copy link

@tompro tompro commented Mar 28, 2011

If I use renameNx and rename a key to a key that is currently not existing the operation is performed well on Redis server. Nevertheless I get false as result from phpredis.

The follwing test fails:

$redis->set('oldkey', 'value');
$this->assertTrue(
    $redis->renameNx('oldkey', 'newkey')
);
@nicolasff
Copy link
Contributor

@nicolasff nicolasff commented Mar 28, 2011

Hello,

Thanks for this report. I'll have a look tomorrow morning and integrate your test.
@tompro
Copy link
Author

@tompro tompro commented Mar 29, 2011

Cool. Thanks for this fast reply.
@nicolasff
Copy link
Contributor

@nicolasff nicolasff commented Mar 30, 2011

Hello again,

It seems that the either the return value of RENAMENX has changed in Redis itself, or this bug has been here for a long time. I have fixed this issue and added a unit test.

Could you please confirm that it works as expected?
@tompro
Copy link
Author

@tompro tompro commented Mar 30, 2011

Works like a charm. All green :) . During the next weeks I am going to cover most phpredis functions with tests as I am currently building a higher level library. I'll let you know when I encounter something else. I hope this is not very anoying for you :) .
@tompro tompro closed this Mar 30, 2011
@nicolasff
Copy link
Contributor

@nicolasff nicolasff commented Mar 30, 2011

Not at all, thanks for reporting this. The more I can fix, the better it will be :-)
@askie askie mentioned this issue Oct 20, 2011
Closed
@chuyskywalker chuyskywalker mentioned this issue Nov 7, 2011
Closed
@abrosimov abrosimov mentioned this issue Mar 11, 2012
Closed
@headzoo headzoo mentioned this issue Mar 24, 2012
Closed
@kyleamadio kyleamadio mentioned this issue Apr 18, 2012
Closed
@dmitry-saritasa dmitry-saritasa mentioned this issue May 17, 2012
Closed
@omerhasan omerhasan mentioned this issue May 18, 2012
Closed
@cirruspath cirruspath mentioned this issue Jun 11, 2012
Closed
@pesiwang pesiwang mentioned this issue Aug 14, 2012
Closed
@songerzhou songerzhou mentioned this issue Aug 29, 2012
Closed
@larest larest mentioned this issue Aug 29, 2012
Closed
@tritondigital tritondigital mentioned this issue Dec 11, 2012
Closed
@larest larest mentioned this issue Oct 10, 2013
Closed
@hanyh2004 hanyh2004 mentioned this issue Oct 15, 2013
Closed
@edlerd edlerd mentioned this issue Oct 30, 2013
Closed
@hanyh2004 hanyh2004 mentioned this issue Nov 4, 2013
Closed
@anton000 anton000 mentioned this issue Feb 10, 2014
Closed
@michael-grunder michael-grunder mentioned this issue Feb 21, 2014
Closed
@pandao pandao mentioned this issue Apr 7, 2014
Closed
@alfrekjv alfrekjv mentioned this issue Jul 10, 2014
Closed
@BigShaby BigShaby mentioned this issue Mar 5, 2015
Closed
@DartBond DartBond mentioned this issue Apr 2, 2015
Closed
@huyanping huyanping mentioned this issue May 15, 2015
Closed
@nailding1 nailding1 mentioned this issue Jun 19, 2015
Closed
@pqzhou2005 pqzhou2005 mentioned this issue Apr 9, 2016
Closed
@NerdyProjects NerdyProjects mentioned this issue Apr 21, 2016
Closed
@destinyac destinyac mentioned this issue Jul 9, 2016
Closed
@bournes bournes mentioned this issue Jul 9, 2016
Open
@michbsd michbsd mentioned this issue Jul 11, 2016
Closed
@andyli029 andyli029 mentioned this issue Jul 15, 2016
Closed
@bigfg bigfg mentioned this issue Aug 9, 2016
Closed
@fotografi
Copy link

@fotografi fotografi commented Aug 12, 2016

No description provided.

@vkirovskiy vkirovskiy mentioned this issue Sep 19, 2016
Closed
@yushengery yushengery mentioned this issue Sep 23, 2016
Closed
@liuzexin liuzexin mentioned this issue Oct 14, 2016
Closed
@ajbonner ajbonner mentioned this issue Dec 28, 2016
Closed
@wangjinbei wangjinbei mentioned this issue Jan 21, 2017
Closed
@liupdhc liupdhc mentioned this issue Apr 12, 2017
Closed
@hilocz hilocz mentioned this issue Apr 17, 2017
Closed
@observerx observerx mentioned this issue Aug 29, 2017
Closed
0 of 2 tasks complete
This was referenced Dec 5, 2017
Closed
Closed
Merged
@sreeraagbuyt sreeraagbuyt mentioned this issue Mar 13, 2018
Closed
michael-grunder pushed a commit that referenced this issue Nov 16, 2018
@yulonghu
Merge pull request #1 from phpredis/develop
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8918b3e 
merge phpredis::develop
@vityank vityank mentioned this issue Dec 19, 2018
Closed
@RasmusWernerLarsen RasmusWernerLarsen mentioned this issue Apr 3, 2019
Closed
1 of 2 tasks complete
@egege egege mentioned this issue Jun 10, 2019
Closed
@zorro-fr24 zorro-fr24 mentioned this issue Jul 5, 2019
Closed
@kalmykov kalmykov mentioned this issue Aug 2, 2019
Closed
1 of 2 tasks complete
@Vidalia Vidalia mentioned this issue Aug 12, 2019
Closed
1 of 2 tasks complete
@nitesh- nitesh- mentioned this issue Oct 26, 2019
Closed
@sofire sofire mentioned this issue Jan 14, 2020
Closed
@xiaoliwang xiaoliwang mentioned this issue Jul 23, 2020
Open
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
work in progress
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@nicolasff @tompro @fotografi
You can’t perform that action at this time.