★ wanayoo — archive 1999 https://github.com/pytest-dev/pytest-html/pull/264Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Add command line parameter to support custom javascript #264

Open
wants to merge 2 commits into
base: master
from

Conversation

@ExaltedBagel
Copy link
Contributor

ExaltedBagel commented Feb 7, 2020

As per issue #182, support for the addition of javascript files has been added.

The main.js file was modified to add the stub functions pre_init and post_init to make it easier to add behaviours on init.

ExaltedBagel added 2 commits Feb 7, 2020
…the --js parameter.

Added two conveniance functions to main.js: preInit and postInit. Those methods are defined as blanks, and are
called respectively before and after the default init() function. This should allow to easily integrate most
solutions as wrapper around the default init. If not, people are free to redefine their own init.

Fixes #182
…the code for css is the same), support for

multiple js files was added.
@ExaltedBagel
Copy link
Contributor Author

ExaltedBagel commented Feb 7, 2020

I have tested the report generation manually, but I am uninspired as how I should go about adding it to the test suite. Would you have any ideas?

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Feb 10, 2020

Honestly, the JS testing stuff is a bit of a black box to me. It's also before my time as a maintainer.

Maybe @rochacbruno or @davehunt can help? 🙏

@davehunt
Copy link
Collaborator

davehunt commented Feb 10, 2020

Unfortunately I can't be much help here. This was introduced by @RibeiroAna and any understanding I had of it has faded in the time since. Given that, I would say that it's fair game for a fresh approach if anyone has ideas.

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Feb 10, 2020

Unfortunately I can't be much help here. This was introduced by @RibeiroAna and any understanding I had of it has faded in the time since. Given that, I would say that it's fair game for a fresh approach if anyone has ideas.

I would love for us to refactor the JS tests to use something modern like Jest.

@ExaltedBagel
Copy link
Contributor Author

ExaltedBagel commented Feb 11, 2020

@BeyondEvil I am open to learning Jest and refactoring the current test suite to use it. This however extends the scope I had envisioned. It will delay the feature by a few weeks since I will be travelling next week. I will keep you posted!

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Feb 28, 2020

ping @ExaltedBagel 😊

@ExaltedBagel
Copy link
Contributor Author

ExaltedBagel commented Feb 28, 2020

Heya @BeyondEvil! Came back from vacations three days ago, and was bed sick until today. I still got a splitting head ache to go through, then I'll get on with learning Jest (unless someone is waiting in line to do so, then they could move along with the refactor and I could adjust my code afterwards)

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Feb 28, 2020

Feel better @ExaltedBagel !

@ssbarnea ssbarnea added the feature label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.