Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP]: Add command line parameter to support custom javascript #264
Conversation
…the --js parameter. Added two conveniance functions to main.js: preInit and postInit. Those methods are defined as blanks, and are called respectively before and after the default init() function. This should allow to easily integrate most solutions as wrapper around the default init. If not, people are free to redefine their own init. Fixes #182
…the code for css is the same), support for multiple js files was added.
|
I have tested the report generation manually, but I am uninspired as how I should go about adding it to the test suite. Would you have any ideas? |
|
Honestly, the JS testing stuff is a bit of a black box to me. It's also before my time as a maintainer. Maybe @rochacbruno or @davehunt can help? |
|
Unfortunately I can't be much help here. This was introduced by @RibeiroAna and any understanding I had of it has faded in the time since. Given that, I would say that it's fair game for a fresh approach if anyone has ideas. |
I would love for us to refactor the JS tests to use something modern like Jest. |
|
@BeyondEvil I am open to learning Jest and refactoring the current test suite to use it. This however extends the scope I had envisioned. It will delay the feature by a few weeks since I will be travelling next week. I will keep you posted! |
|
ping @ExaltedBagel |
|
Heya @BeyondEvil! Came back from vacations three days ago, and was bed sick until today. I still got a splitting head ache to go through, then I'll get on with learning Jest (unless someone is waiting in line to do so, then they could move along with the refactor and I could adjust my code afterwards) |
|
Feel better @ExaltedBagel ! |
ExaltedBagel commentedFeb 7, 2020
As per issue #182, support for the addition of javascript files has been added.
The main.js file was modified to add the stub functions pre_init and post_init to make it easier to add behaviours on init.