★ wanayoo — archive 1999 https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/issues/218Nouvelle recherche | Portail wanayoo
Skip to content

/ python-cmake-buildsystem

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch command not found despite being found. #218

Closed
adrianbroher opened this issue Mar 24, 2018 · 4 comments
Closed

Patch command not found despite being found. #218

adrianbroher opened this issue Mar 24, 2018 · 4 comments

Comments

@adrianbroher
Copy link
Contributor

@adrianbroher adrianbroher commented Mar 24, 2018

Hello,

the current master e5d2880 claims that there is no suitable patch command available, despite locating two patch applications with suitable versions right before that statement. Looking into the code I don't see any reason why it shouldn't work.

-- Looking for CMake property POSITION_INDEPENDENT_CODE - found
-- SRC_DIR: /Users/travis/build/[secure]/[secure]-sdk/build/python-prefix/src/python
-- PY_VERSION: 2.7.14
-- Found Git: /Applications/Xcode.app/Contents/Developer/usr/bin/git (found version "2.3.2 (Apple Git-55)") 
-- Found Patch: /usr/local/bin/patch (found version "2.7.6") 
CMake Error at cmake/PythonApplyPatches.cmake:41 (message):
  Could NOT find a suitable version of Git or Patch executable to apply
  patches.
Call Stack (most recent call first):
  CMakeLists.txt:293 (include)
-- Configuring incomplete, errors occurred

The full log can be found here with the relevant chunk highlighted.
@jcfr
Copy link
Contributor

@jcfr jcfr commented Mar 24, 2018

Thanks for the report.

It is strange that it reports finding both Git and Patch

-- Found Git: /Applications/Xcode.app/Contents/Developer/usr/bin/git (found version "2.3.2 (Apple Git-55)") 
-- Found Patch: /usr/local/bin/patch (found version "2.7.6")

Based on the implementation, if Git_FOUND is True .. it should define the PATCH_COMMAND and move forward.

For some reason, Git_FOUND is set to FALSE ...
@jcfr
Copy link
Contributor

@jcfr jcfr commented Mar 24, 2018 •
edited

I wonder if the problem is due to freeorion/freeorion-sdk@e9c4f51 ... but I can't see why it would cause the issue.

Seeing the variable PATCH_COMMAND just made me think that the same variable is used in PythonApplyPatches.cmake

Side question: in the folder patches/python-cmake, there are a lot of patches ... following the update, are they all needed ? I think we should be able to integrate most of them.
@jcfr
Copy link
Contributor

@jcfr jcfr commented Mar 24, 2018

Looking at the new build: https://travis-ci.org/freeorion/freeorion-sdk/jobs/357727393#L3563-L3571

It does not seem that the project is configured or built.
@adrianbroher
Copy link
Contributor Author

@adrianbroher adrianbroher commented Mar 24, 2018

I think we should be able to integrate most of them.

Ahem #196 #182

;)

But yes, you're right. They should be integrated into upstream. I wanted to make sure first that the updated build is working properly so I can present updated PRs.
adrianbroher added a commit to adrianbroher/python-cmake-buildsystem that referenced this issue Mar 24, 2018
@adrianbroher
Use upper case *_FOUND variables when locating `patch`
370fb06 
Fixes python-cmake-buildsystem#218
@adrianbroher adrianbroher mentioned this issue Mar 24, 2018
Merged
jcfr added a commit to adrianbroher/python-cmake-buildsystem that referenced this issue Mar 24, 2018
@adrianbroher @jcfr
PythonApplyPatches: Use upper & lowercase *_FOUND vars when locating …
Unverified
This user has not uploaded their public key yet.
GPG key ID: A50C0312039D473C Learn about signing commits
143b77c 
…git & patch

This allows to support version of CMake < 3.3 that do not have a version
of the FindPackageHandleStandardArgs (see Kitware/CMake@d1a6d15) setting
both variables.

Fixes python-cmake-buildsystem#218
@jcfr jcfr closed this in #219 Mar 25, 2018
dand-oss pushed a commit to dand-oss/python-cmake-buildsystem that referenced this issue Feb 19, 2019
@adrianbroher Dan Dees
PythonApplyPatches: Use upper & lowercase *_FOUND vars when locating …
b01eeef 
…git & patch

This allows to support version of CMake < 3.3 that do not have a version
of the FindPackageHandleStandardArgs (see Kitware/CMake@d1a6d15) setting
both variables.

Fixes python-cmake-buildsystem#218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@adrianbroher @jcfr
You can’t perform that action at this time.