★ wanayoo — archive 1999 https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/151Nouvelle recherche | Portail wanayoo
Skip to content

/ python-cmake-buildsystem

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build debug libraries when CMAKE_BUILD_TYPE is set to Debug #151

Closed
wants to merge 4 commits into from
Closed

Build debug libraries when CMAKE_BUILD_TYPE is set to Debug #151

wants to merge 4 commits into from

Conversation

@dbrnz
Copy link
Contributor

@dbrnz dbrnz commented Aug 29, 2016

This should address issue #12.
dbrnz added 3 commits Aug 28, 2016
@dbrnz
Add `_d` postfix to MS Windows library names for CMake debug builds.
f0d78e3
@dbrnz
Debug builds can't have `Py_LIMITED_API` set.
10a95d0
@dbrnz
Only add `_d` postfix to Windows debug builds when using Microsoft's …
Loading status checks…
4ef3857 
…compilers.
@jcfr
Copy link
Contributor

@jcfr jcfr commented Sep 5, 2016

Thanks for the patch 👍 I will review and integrate later this week.
CMakeLists.txt Outdated
@@ -33,6 +33,10 @@ if(CMAKE_CROSSCOMPILING)
cmake_minimum_required(VERSION 3.3) # Version introducing CROSSCOMPILING_EMULATOR
endif()

if(WIN32 AND "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")

This comment has been minimized.

Sign in to view
@adrianbroher

adrianbroher Sep 10, 2016
Contributor

The CMAKE_DEBUG_POSTFIX variable only preseeds the Debug build type suffix, so there is no need to add that to the condition.

https://cmake.org/cmake/help/v2.8.5/cmake.html#variable:CMAKE_DEBUG_POSTFIX

This comment has been minimized.

Sign in to view
@dbrnz

dbrnz Sep 16, 2016
Author Contributor

Thanks @adrianbroher, the redundant check on CMAKE_BUILD_TYPE has been removed.
@dbrnz
Remove redundant test on CMAKE_BUILD_TYPE.
Loading status checks…
2ae5027
@jcfr jcfr added the enhancement label Feb 15, 2017
@jcfr jcfr mentioned this pull request Dec 13, 2018
Open
@jcfr jcfr closed this Dec 13, 2018
@dbrnz dbrnz deleted the dbrnz:windebug branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@dbrnz @jcfr @adrianbroher
You can’t perform that action at this time.