Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uppyconfig: Check for _LARGEFILE_SOURCE definition inconsistency #167
Conversation
When embedding Python in other application, it is not practical to follow the official recommendations [1] asking to include "Python.h" first. Failing to do so can also causes "redefinition" warnings (see previous commit), to mitigate this while ensuring Python code is compiled with the expected ABI [2], this commit checks if previous definitions of _LARGEFILE_SOURCE are consistent with the value expected by CPython build system. [1] https://docs.python.org/3/c-api/intro.html#include-files [2] http://bugs.python.org/issue1045893#msg22669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When embedding Python in other application, it is not practical to
follow the official recommendations [1] asking to include "Python.h" first.
Failing to do so can also causes "redefinition" warnings (see previous
commit), to mitigate this while ensuring Python code is compiled
with the expected ABI [2], this commit checks if previous definitions
of _LARGEFILE_SOURCE are consistent with the value expected by CPython
build system.
[1] https://docs.python.org/3/c-api/intro.html#include-files
[2] http://bugs.python.org/issue1045893#msg22669