★ wanayoo — archive 1999 https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/202Nouvelle recherche | Portail wanayoo
Skip to content

/ python-cmake-buildsystem

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set_target_properties on an extension when it's disabled. #202

Open
wants to merge 1 commit into
base: master
from
Open

Don't set_target_properties on an extension when it's disabled. #202

wants to merge 1 commit into from

Conversation

@gongminmin
Copy link

@gongminmin gongminmin commented Dec 30, 2017

When ENABLE_{extension} is explicitly set to OFF, don't need to call the set_target_properties on that extension.
@gongminmin
Don't set_target_properties on an extension when it's disabled.
Loading status checks…
dbd3ae3
@gongminmin
Copy link
Author

@gongminmin gongminmin commented Dec 31, 2017

Somehow travis ci failed. But those failed case is still "100% tests passed, 0 tests failed out of 392" in their details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@gongminmin
You can’t perform that action at this time.