★ wanayoo — archive 1999 https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/254Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.7.4 #254

Closed

Conversation

@dand-oss
Copy link

@dand-oss dand-oss commented Aug 4, 2019

Python 3.7.4 WORKING on Linux and Windows for release and debug.

Apple should not take much to fix _ctypes, if needed.

Next step: make the 3.7 changes backwards compatible.

Ex
config_3.c.in

-    {"_imp", PyInit_imp},
+    {"_imp", PyInit__imp}, /* 3.7 was single _ */

Need some #define incantations to work with previous python versions.

This pull shows as separate commits the changes needed to run 3.7.

@dbrnz
Copy link
Contributor

@dbrnz dbrnz commented Aug 6, 2019

Hmm, you've beaten my to it! I guess we need to compare and merge my PR #256 with yours...

@dbrnz dbrnz mentioned this pull request Aug 6, 2019
@jcfr
Copy link
Contributor

@jcfr jcfr commented Aug 6, 2019

Thanks for the contribution 🙏

Closing. Change integrated in #256

@jcfr jcfr closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.