Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary runtime dependency on setuptools #1006
Conversation
The package does not seem to use setuptools or pkg_resources anywhere, and the dependency is probably leftover after migration to importlib.metadata.
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 22 22
Lines 4613 4613
=======================================
Hits 4516 4516
Misses 97 97 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The package does not seem to use setuptools or pkg_resources anywhere,
and the dependency is probably leftover after migration to
importlib.metadata.