Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow minreal to work with static gain StateSpace objects #108
Conversation
…ects. Allows StateSpace([],[],[],D), which failed previously. Static gains have sizes enforced as follows: A 0-by-0, B 0-by-ninputs, C noutputs-by-0. Tests added for instantiation, and sum, product, feedback, and appending, of 1x1, 2x3, and 3x2 static gains StateSpace objects.
On Python 2.7, the special case "all states useless" in _remove_useless_states resulted in A=[[0]] (and similarly for B and C). The special case is no longer needed, since empty A, B, C matrices can be handled. numpy.delete does the right thing w.r.t. matrix sizes (e.g., deleting all columns of a nxm matrix gives an nx0 matrix). Added test for this.
Do this by only calling Slycot's tb01pd for non-static systems.
|
Pull request #110 subsumes this one. |
Finding this bug is what provoked #107, which this builds on.
This takes the simple option of doing nothing for a static gain. I didn't investigate the slycot.tb01pd call at all; perhaps it can take a static gain, and there's some other bug lurking in minreal code.