★ wanayoo — archive 1999 https://github.com/python-trio/trio/pull/82Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `python3 -m pip` over `pip` #82

Merged
merged 3 commits into from Mar 11, 2017
Merged

Conversation

@brettcannon
Copy link
Contributor

@brettcannon brettcannon commented Mar 11, 2017

No description provided.

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 11, 2017

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          50       50           
  Lines        5876     5876           
  Branches      464      464           
=======================================
  Hits         5776     5776           
  Misses         86       86           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bf8b6...393b9bf. Read the comment docs.

@njsmith
Copy link
Member

@njsmith njsmith commented Mar 11, 2017

ugh what do you mean there are still people who aren't running py3 as default

Is this correct on Windows too? (the whole py thing confuses me.) And the README probably needs to be fixed as well.

@brettcannon
Copy link
Contributor Author

@brettcannon brettcannon commented Mar 11, 2017

😄 I honestly promote it more for e.g. 3.5 vs 3.6.

And on Windows it depends on how they install it. Everyone gets py, so it can be py -3 -m pip, but you can choose to put python3 on PATH.

brettcannon added 2 commits Mar 11, 2017
@brettcannon
Copy link
Contributor Author

@brettcannon brettcannon commented Mar 11, 2017

Updated for Windows and updated the README.

I should start that conversation again about getting a py equivalent on UNIX again.

@njsmith
Copy link
Member

@njsmith njsmith commented Mar 11, 2017

Thanks!

@njsmith njsmith merged commit 5e661a2 into python-trio:master Mar 11, 2017
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 08bf8b6...393b9bf
Details
codecov/project 98.29% remains the same compared to 08bf8b6
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brettcannon brettcannon deleted the brettcannon:patch-2 branch Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.