★ wanayoo — archive 1999 https://github.com/pythongssapi/python-gssapi/issues/215Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port away from should_be #215

Open
frozencemetery opened this issue Jul 7, 2020 · 2 comments · May be fixed by #219
Open

Port away from should_be #215

frozencemetery opened this issue Jul 7, 2020 · 2 comments · May be fixed by #219
Assignees
Labels

Comments

@frozencemetery
Copy link
Member

@frozencemetery frozencemetery commented Jul 7, 2020

should_be doesn't work with python-3.8 and it's unmaintained, so we need something else before fc31 testing stops being viable.

@stanislavlevin
Copy link
Contributor

@stanislavlevin stanislavlevin commented Jul 8, 2020

Hi, @frozencemetery. Some time ago I filed the identical issue #130. Since that time I build python-gssapi for my distro without should_be. If somebody interests I could open related PR.

@frozencemetery
Copy link
Member Author

@frozencemetery frozencemetery commented Jul 8, 2020

Unless I'm missing something, #130 is for something different: our test suite works just fine up through 3.7 as far as I can tell. (Certainly it works on fedora 31, which is python3-3.7.8-1.fc31, so...)

I am of course happy to consider pull requests to address this issue :) Please do submit them in the form of pull requests (and not attached .patch files).

@frozencemetery frozencemetery added the test label Jul 8, 2020
stanislavlevin added a commit to stanislavlevin/python-gssapi that referenced this issue Jul 10, 2020
Change should_be assertions to unittest(stdlib) ones.
should_be is unmaintained and doesn't work against Python3.8.

Fixes: pythongssapi#215
stanislavlevin added a commit to stanislavlevin/python-gssapi that referenced this issue Jul 10, 2020
Change should_be assertions to unittest(stdlib) ones.
should_be is unmaintained and doesn't work against Python3.8.

Fixes: pythongssapi#215
stanislavlevin added a commit to stanislavlevin/python-gssapi that referenced this issue Jul 10, 2020
Migrate should_be assertions to unittest(stdlib) ones.
This requires Python3.2+.

Fixes: pythongssapi#215
Signed-off-by: Stanislav Levin <slev@altlinux.org>
@stanislavlevin stanislavlevin linked a pull request that will close this issue Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.