Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix shlex.split on windows #223
Merged
Conversation
|
Thanks, this seems good to me, but I'd like to double-check with @aiudirog before merging. |
|
I have no problems with this, sounds like a good change. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I'm trying to compile this package on Windows for
conda-forgeso need to pass in theGSSAPI_LINKER_ARGSandGSSAPI_COMPILER_ARGSenv vars. Unfortunately they're specified using the Windows backslash convention for paths which requires passing theposix=Falseargument toshlex.split