★ wanayoo — archive 1999 https://github.com/scanapi/scanapi/issues/322Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 python style formatting to pre-commit #322

Closed
camilamaia opened this issue Oct 22, 2020 · 3 comments
Closed

Add flake8 python style formatting to pre-commit #322

camilamaia opened this issue Oct 22, 2020 · 3 comments
Assignees
@NimishVerma
Labels
Automation Hacktoberfest
Projects
Hacktoberfest 2020

Comments

@camilamaia
Copy link
Member

@camilamaia camilamaia commented Oct 22, 2020 •
edited

Add flake8 Python style formatting to pre-commit

File to add configuration: https://github.com/scanapi/scanapi/blob/master/.pre-commit-config.yaml
More info at: https://ljvmiranda921.github.io/notebook/2018/06/21/precommits-using-black-and-flake8/

Configuration should match with flake8 github action check: #321
@camilamaia camilamaia added Automation Hacktoberfest labels Oct 22, 2020
@camilamaia camilamaia added this to To do in Hacktoberfest 2020 via automation Oct 22, 2020
@NimishVerma
Copy link
Contributor

@NimishVerma NimishVerma commented Oct 22, 2020 •
edited

Hi, I would like to work on this. The configuration link seems to be private or non-existent since it returns 404.

@camilamaia
Copy link
Member Author

@camilamaia camilamaia commented Oct 23, 2020

Hi, I would like to work on this. The configuration link seems to be private or non-existent since it returns 404.

Hi! It is because the PR was not merged yet. But I changed the description with a proper link, thanks!

I will assign this issue to you 👍

camilamaia pushed a commit that referenced this issue Oct 31, 2020
@NimishVerma
Adds flake8 checks and configs #322 (#323)
1186f83 
Added flake8 to pre-commit
@camilamaia
Copy link
Member Author

@camilamaia camilamaia commented Oct 31, 2020

Closed by #323

@camilamaia camilamaia closed this Oct 31, 2020
Hacktoberfest 2020 automation moved this from To do to Done Oct 31, 2020
flaviotruzzi pushed a commit to flaviotruzzi/scanapi that referenced this issue Nov 19, 2020
@NimishVerma
Adds flake8 checks and configs scanapi#322 (scanapi#323)
45f5401 
Added flake8 to pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NimishVerma NimishVerma

Labels
Automation Hacktoberfest
Projects
No open projects
Hacktoberfest 2020
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@camilamaia @NimishVerma