Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upset window focus fix #473
Closed
set window focus fix #473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 75.06% 74.93% -0.13%
==========================================
Files 5 5
Lines 794 794
Branches 231 231
==========================================
- Hits 596 595 -1
Misses 146 146
- Partials 52 53 +1
Continue to review full report at Codecov.
|
|
I can confirm that the above fix works for me. In addition, it seems that the Travis CI check failed due to network error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #326.
Existing hook sets focus to some window, but it does not set the focus back to the last (previously selected) window, but to the previous window (previous in the list of windows in the session).
My commit fixes this without any deeper knowledge about the hook itself.
Unfortunately the hook tells "no last window" to me now.