★ wanayoo — archive 1999 https://github.com/tmux-python/tmuxp/pull/487Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume no panes specified for a window means one pane with no commands #487

Merged
merged 1 commit into from May 13, 2019

Conversation

@kstilwell
Copy link
Contributor

@kstilwell kstilwell commented May 12, 2019

If window is specified in tmuxp configuration without panes assume that means one pane with no shell commands is intended.

Address #470

@tony tony self-requested a review May 12, 2019
@tony
Copy link
Member

@tony tony commented May 12, 2019

@kstilwell I think black/isort has to be ran.

I'm adding it to pipenv in master (forgot to earlier). I made it so Pipfile using python 3 now, you may have to recrease your virtualenv

(You can disregard below if you have a better way of cleaning up your PR, I just merged a lot of stuff into master in the past few minutes)

Rebase against master

  • git checkout issue_170_fix

  • git pull --rebase origin master --autostash (replace origin with the name of the remote pointing to tmux-python's repo)

  • deactivate

  • pipenv --remove

  • pipenv install -d

Then

make black isort

To rebase the changes onto the last commit you made:

  • git add .
  • git commit --amend
  • git push --force-with-lease
@tony
tony approved these changes May 12, 2019
Copy link
Member

@tony tony left a comment

After tests pass, LGTM

- If window is specified in tmuxp configuration without panes assume that means one pane with no shell commands is intended
@codecov-io
Copy link

@codecov-io codecov-io commented May 13, 2019

Codecov Report

Merging #487 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   75.06%   75.31%   +0.25%     
==========================================
  Files           5        5              
  Lines         794      794              
  Branches      231      231              
==========================================
+ Hits          596      598       +2     
+ Misses        146      145       -1     
+ Partials       52       51       -1
Impacted Files Coverage Δ
tmuxp/config.py 86.17% <100%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db7b9d4...6ad4b8d. Read the comment docs.

@tony tony merged commit 9e1212f into tmux-python:master May 13, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 75.06%)
Details
codecov/project 75.31% (+0.25%) compared to db7b9d4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.