Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding Plugin System #628
Adding Plugin System #628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 77.12% 79.23% +2.10%
==========================================
Files 6 7 +1
Lines 883 963 +80
Branches 251 266 +15
==========================================
+ Hits 681 763 +82
+ Misses 137 133 -4
- Partials 65 67 +2
Continue to review full report at Codecov.
|
fea9868
to
f7f369a
|
@joseph-flinn Try rebasing (I fixed an issue with poetry), running |
|
Lets aim to get this in the next release (and last Python 2.7 release) This will assure packaged versions of tmuxp on BSD/Linux and systems using python 2.7 have a plugin system. |
9108ddd
to
50dec52
…the desired plugin api methods
…t with stubbed solution
…with python for testing purposes. Started rudimentary config testing. Started working on the cli.load_plugins test.
…nto the workspacebuilder and changed the reattach to take in a builder object instead of a session so that it can access those plugins.
…pdating corresponding tests. Starting on the documentation
…lugin function and corresponding tests. Add a way to skip loading a plugin if it failed to load
…kipping plugin load if the fail
3d04d7c
to
6c036bf
|
Note: The bump in version is required for the extensive testing of the plugin system. The test plugins all depend on tmuxp version 1.6.0 (I believe this is the next release that will contain this feature?) |
Yes, this version bump and the constraint seems appropriate. |
Plugin system QA / tweaks
Example: Rename PluginInterface -> Plugin
|
@joseph-flinn Can you rebase this? (I know from email you're not around today) |
Adding most of the logic for the Plugin System from #530. I have done some initial manual testing and it seems to be working.
Design Decisions:
before_scriptin the tmuxp config will run before anything in theplugin.before_scriptmethod)plugin.on_window_createmethod is referring to when tmuxp is creating new windows versus the user creating a new window in tmuxplugin.after_window_finishedmethod is referring to after the window is done being setup versus when the tmux user closes the windowCurrently missing: