★ wanayoo — archive 1999 https://github.com/xtensor-stack/xtensor/pull/2034Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "xvector" #2034

Draft
wants to merge 1 commit into
base: master
from
Draft

Adding "xvector" #2034

wants to merge 1 commit into from

Conversation

@tdegeus
Copy link
Member

@tdegeus tdegeus commented Apr 18, 2020

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

Fixes #2020

@tdegeus
Copy link
Member Author

@tdegeus tdegeus commented Apr 18, 2020 •

@JohanMabille A first question: xtensor does not have resize, while I think xvector should ?

(Don't look at the code yet)

@tdegeus tdegeus marked this pull request as draft Apr 18, 2020
@JohanMabille
Copy link
Member

@JohanMabille JohanMabille commented Apr 19, 2020

resize is provided by the base class xstrided_container. However, xvector should not inherit from xstrided_container but rather provide its own implementation or resize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.