Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd multiple features, bug fixes and update libssh2 to the latest stable. #90
Conversation
This enables giving ssh a prefered list of options such as kex, ciphers, MACs and etc
Add libsssh2_session_method_pref
Add recompiled cython files
Regenerate Cython files. Add `ssh2.session.Session.method_pref()` doc string. Update .gitignore to include src directory to ignore libssh2 rebuilds.
Add additional error codes. Add `session.method_pref()` docs and tests. Add `session.methods()`, docs and tests. Add `session.supported_algs()`, docs and tests. Add `session.flag()`, docs and tests. Bug fix for `session.userauth_publickey_frommemory()` being provided no public key and throwing a type error.
Add callback function typedef for keyboard interactive authentication. Add `ctypedef`s for keyboard interactive authentication. Fix keyboard interactive authentication function def in c_ssh. Internally hide that `libssh2_userauth_keyboard_interactive` takes a callback function and not a string...
|
Also appears that the LFS allowance for travis and appveyor has run out. |
|
@pkittenis Is there something that I need to do that I've missed? |
bb45389
to
ac1687a
llchan
commented
Jun 23, 2020
|
@pkittenis are you still maintaining this project? This PR has been incubating for quite some time and fixes many outstanding issues. @Red-M I appreciate the work put in here + to get it out on pypi so it's more easily accessible. That said, would you mind cutting a new/edited PR in this repo that points to a commit before you made some of the renaming changes in your master branch? It would be better to merge your changes here rather than forking off forever, and in its current state the PR has unrelated changes. |
|
@llchan I'd love to but GitHub doesn't support changing the target branch of a PR. I'll have to open a new one and reference it in an edit on the first post and in the new PR. The only reason I opened this PR was mostly because I wasn't getting any response form the maintainer here and since this library requires a wheel to be built, I realised that I had to rename and then everyone could actually use it (since most people don't keep/install dev headers/packages on their systems which means the wheel can't be built for that system without a bunch of new packages/libraries being installed). |
|
Please see #94 instead of this PR as I've forked under a new name to publish on pypi. |
Red-M commentedNov 6, 2019
•
edited
New PR at #94