★ wanayoo — archive 1999 https://github.com/ParallelSSH/ssh2-python/pull/90Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple features, bug fixes and update libssh2 to the latest stable. #90

Closed
wants to merge 32 commits into from

Conversation

@Red-M
Copy link

Red-M commented Nov 6, 2019

New PR at #94

dvolodin7 and others added 13 commits May 8, 2019
This enables giving ssh a prefered list of options such as
kex, ciphers, MACs and etc
Add libsssh2_session_method_pref
Add recompiled cython files
Regenerate Cython files.
Add `ssh2.session.Session.method_pref()` doc string.
Update .gitignore to include src directory to ignore libssh2 rebuilds.
Add additional error codes.
Add `session.method_pref()` docs and tests.
Add `session.methods()`, docs and tests.
Add `session.supported_algs()`, docs and tests.
Add `session.flag()`, docs and tests.
Bug fix for `session.userauth_publickey_frommemory()` being provided no public key and throwing a type error.
@Red-M Red-M changed the title Multiple feature and bug fixes. Add multiple features and bug fixes. Nov 6, 2019
@Red-M
Copy link
Author

Red-M commented Nov 6, 2019

This should superseed #80 and #75 while fixing #89, #86 and adding new functions with docs and tests completed.

Red-M added 2 commits Nov 9, 2019
Add callback function typedef for keyboard interactive authentication.
Add `ctypedef`s for keyboard interactive authentication.
Fix keyboard interactive authentication function def in c_ssh.
Internally hide that `libssh2_userauth_keyboard_interactive` takes a callback function and not a string...
@Red-M
Copy link
Author

Red-M commented Nov 9, 2019

This now also properly implements #58 by fixing the bug in #76 and will close #84.

@Red-M
Copy link
Author

Red-M commented Nov 9, 2019

Also appears that the LFS allowance for travis and appveyor has run out.

@Red-M Red-M changed the title Add multiple features and bug fixes. Add multiple features, bug fixes and update libssh2 to the latest stable. Nov 9, 2019
@Red-M
Copy link
Author

Red-M commented Nov 17, 2019

@pkittenis Is there something that I need to do that I've missed?

Red-M added 6 commits Dec 8, 2019
Add enums to clean up any symbols from libssh2 and make interacting with them much easier to do.
Add additional unit tests for #86
@Red-M Red-M mentioned this pull request Feb 16, 2020
Red-M added 8 commits Feb 16, 2020
Correct issue in `ssh2.sftp_handel.SFTPHandle.readdir*()` which adds EAGAIN items into the generators.
Rename library to redlibssh2.
@Red-M Red-M force-pushed the Red-M:master branch 2 times, most recently from bb45389 to ac1687a Jun 13, 2020
@Red-M Red-M force-pushed the Red-M:master branch from 712b21a to a0dd7d0 Jun 13, 2020
@llchan
Copy link

llchan commented Jun 23, 2020

@pkittenis are you still maintaining this project? This PR has been incubating for quite some time and fixes many outstanding issues.

@Red-M I appreciate the work put in here + to get it out on pypi so it's more easily accessible. That said, would you mind cutting a new/edited PR in this repo that points to a commit before you made some of the renaming changes in your master branch? It would be better to merge your changes here rather than forking off forever, and in its current state the PR has unrelated changes.

@Red-M
Copy link
Author

Red-M commented Jun 25, 2020

@llchan I'd love to but GitHub doesn't support changing the target branch of a PR. I'll have to open a new one and reference it in an edit on the first post and in the new PR.

The only reason I opened this PR was mostly because I wasn't getting any response form the maintainer here and since this library requires a wheel to be built, I realised that I had to rename and then everyone could actually use it (since most people don't keep/install dev headers/packages on their systems which means the wheel can't be built for that system without a bunch of new packages/libraries being installed).

@Red-M
Copy link
Author

Red-M commented Jun 25, 2020

Please see #94 instead of this PR as I've forked under a new name to publish on pypi.

@Red-M Red-M closed this Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.