Add multiple features, bug fixes and update libssh2 to the latest stable. #94

Red-M · 2020-06-25T10:10:16Z

This is a new PR (from #90) to track the branch of changes for upstream as I see it now that I am required to make my own changes and publish under a new name as it appears the maintainer has disappeared.

The changes are as follows. I also recommend reading the commit messages and the changes on each commit instead of the roll up diff as it is HUGE.

Changes

Update libssh2 to 1.9.0 stable.
Regenerate Cython files.
Update .gitignore to include src directory to ignore libssh2 rebuilds.
Add python 3.8 to appveyor.
Add additional error codes.
Add session.method_pref(), docs and tests.
Add session.methods(), docs and tests.
Add session.supported_algs(), docs and tests.
Add session.flag(), docs and tests.
Bug fix for session.userauth_publickey_frommemory() being provided no public key and throwing a type error.


        Session.userauth_keyboardinteractive method


        flake8


        Add libsssh2_session_method_pref

This enables giving ssh a prefered list of options such as kex, ciphers, MACs and etc


        Merge pull request #1 from getCUJO/add_method-pref_function

Add libsssh2_session_method_pref


        Add recompiled cython files


        Merge pull request #2 from getCUJO/add_method-pref_function

Add recompiled cython files


        userauth_password and userauth_keyboardinteractive tests


        Fix test


        Merge branch 'master' of github.com:ParallelSSH/ssh2-python


        Merge github.com:dvolodin7/ssh2-python


        Update libssh2 to 1.9.0 stable.

Regenerate Cython files. Add `ssh2.session.Session.method_pref()` doc string. Update .gitignore to include src directory to ignore libssh2 rebuilds.


        Update README.rst


        Add python 3.8 to appveyor.

Add additional error codes. Add `session.method_pref()` docs and tests. Add `session.methods()`, docs and tests. Add `session.supported_algs()`, docs and tests. Add `session.flag()`, docs and tests. Bug fix for `session.userauth_publickey_frommemory()` being provided no public key and throwing a type error.


        Fix docstring.


        Add callback enum for c_ssh.

Add callback function typedef for keyboard interactive authentication. Add `ctypedef`s for keyboard interactive authentication. Fix keyboard interactive authentication function def in c_ssh. Internally hide that `libssh2_userauth_keyboard_interactive` takes a callback function and not a string...


        Fix flake8 errors.


        Allow for global name import of the library.

Add enums to clean up any symbols from libssh2 and make interacting with them much easier to do. Add additional unit tests for #86


        Allow travis to ignore git LFS because the repo is over limit.


        Add additional builds on more python 3 versions.


        Regenerated Cython C files with 0.29.6


        Regenerate Cython using 0.29.14


        Add extra host key types to support extra ciphers.


        Also add host key types to the ssh2 enums.


        Fix `ssh2.enums.HOSTKEY_TYPE` enum.

Correct issue in `ssh2.sftp_handel.SFTPHandle.readdir*()` which adds EAGAIN items into the generators.


        Turn libssh2 source tree into git submodule.

Rename library to redlibssh2.

llchan · 2020-06-29T15:43:57Z

Thanks for splitting off dedicated PR branch. Could you revert the changes that rename ssh2 to redlibssh2 in this branch? I assume the maintainer(s) will require that before it can be merged.

Red-M · 2020-06-29T16:07:32Z

Ah bugger, I did not see the 2nd line on that commit message, haha.
I'll see what I can do as I do not want to include someone else's source tree in the repository anymore, it just doesn't make sense to do that and its way better to only track fully released versions as well and this ensures that.
I'll take a look at splitting that commit.

fruch · 2020-07-20T20:48:58Z

seems like appveyor isn't happy

This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

May I suggest trying to move to travis ? (they now support windows and mac)


        Revert name change for upstream.

Red-M · 2020-07-25T15:07:16Z

@llchan
Sorry this took so long but I have been busy with other matters however this should be fine now.

@fruch
Right now I am aiming for redlibssh2 to build packages for manylinux2014 on my own build infrastructure. Once I have packages I can publish to pypi I will be.
I'll also eventually get to travis builds because my build system easily supports that but for now, you should be able to install via my own repo if you'd like to use these patches and be sure you're getting them.

fruch · 2020-07-26T06:21:04Z

@llchan
Sorry this took so long but I have been busy with other matters however this should be fine now.

@fruch
Right now I am aiming for redlibssh2 to build packages for manylinux2014 on my own build infrastructure. Once I have packages I can publish to pypi I will be.
I'll also eventually get to travis builds because my build system easily supports that but for now, you should be able to install via my own repo if you'd like to use these patches and be sure you're getting them.

FYI you can build on travis for multiple platfrom quite easily with cibuildwheel
here's an example of a package i'm maintaining (it's now even has python3.9 wheels):
https://travis-ci.org/github/scylladb/python-driver/builds/711061342
I'll be happy to give a hand with such a setup if you want

It's breaks my heart to see those kind of failures....
https://ci.appveyor.com/project/pkittenis/ssh2-python/builds/34304826/job/4yefexlvgd216bb7

pkittenis · 2020-08-12T15:18:27Z

Thanks for the PR. Have made similar changes, will aim to get these in.

If @Red-M is interested can add you to this project. As has been obvious from this PR, there is only so much one maintainer can do.

pkittenis · 2020-08-12T15:18:49Z

| Thanks for splitting off dedicated PR branch. Could you revert the changes that rename ssh2 to redlibssh2 in this branch? I assume the maintainer(s) will require that before it can be merged.

Yes.

pkittenis · 2020-08-12T15:51:47Z

| I'll be happy to give a hand with such a setup if you want [cibuildwheel]

@fruch , if you would like to take a stab at re-doing the wheel builds for travis CI would welcome a PR.

pkittenis · 2020-08-12T15:53:01Z

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "libssh2"]


Would rather not use submodules. It adds quite a bit of overhead on the developer and can be confusing to work with. The source code is included in the repo so as not to have to use submodules.

I'd prefer to use git submodules as they're designed to do this very thing for tracking a particular remote's branch.
In this PR I've told it to track the 1.9.0 release commit from libssh2's tags/release on github.

All this needs is some work on putting git hooks into the repo with some minor bash scripts. (If libssh2 ever get around to releasing another version that is).

This way we could say switch to a repo of our own choosing for builds if libssh2 doesn't take a patch or is slow to respond to a security issue. It also provides us with git history as well.

Red-M · 2020-08-12T21:21:17Z

@pkittenis

Thanks for the PR. Have made similar changes, will aim to get these in.

If @Red-M is interested can add you to this project. As has been obvious from this PR, there is only so much one maintainer can do.

I'd love to do that.

| Thanks for splitting off dedicated PR branch. Could you revert the changes that rename ssh2 to redlibssh2 in this branch? I assume the maintainer(s) will require that before it can be merged.

Yes.

This has already been done in the latest commit.

pkittenis · 2020-08-13T10:42:34Z

Closing this so can split the various tasks into different PRs. Libssh2 upgrade is being done in #101

In general better to do one thing per PR to make reviewing easier, eg API implementation, libssh2 upgrade, bug fixes etc. This PR has too many unrelated changes to effectively review at once.

Red-M · 2020-09-05T11:18:48Z

@pkittenis RE:

If @Red-M is interested can add you to this project. As has been obvious from this PR, there is only so much one maintainer can do.

What would I need to do for this to be done?

As far as:

can split the various tasks into different PRs

This is a little more difficult than you think as I removed the git commit history that contained LFS objects because it costs money from GitHub to use that and that carrying around packages and installing them is a bad practice instead of letting the OS for the builds handle that.
I'd need to redo the commits to build PRs from scratch.
I'd also need to delete my current fork and recreate it plus recreate my fork as its own repository as I can't create PRs to this repository from the current fork due the aforementioned LFS removal.

dvolodin7 and others added 25 commits May 8, 2019

Session.userauth_keyboardinteractive method

Loading status checks…

32cec58

flake8

Loading status checks…

e06a6c6

Add libsssh2_session_method_pref

a27d6f7

This enables giving ssh a prefered list of options such as kex, ciphers, MACs and etc

Merge pull request #1 from getCUJO/add_method-pref_function

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

7a6f58c

Add libsssh2_session_method_pref

Add recompiled cython files

ba303f5

Merge pull request #2 from getCUJO/add_method-pref_function

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

b7e4cfa

Add recompiled cython files

userauth_password and userauth_keyboardinteractive tests

Loading status checks…

51d0f51

Fix test

Loading status checks…

56391d0

Merge branch 'master' of github.com:ParallelSSH/ssh2-python

3309abf

Merge github.com:dvolodin7/ssh2-python

6147009

Update libssh2 to 1.9.0 stable.

539c435

Regenerate Cython files. Add `ssh2.session.Session.method_pref()` doc string. Update .gitignore to include src directory to ignore libssh2 rebuilds.

Update README.rst

17fd808

Fix docstring.

Loading status checks…

8161461

Fix flake8 errors.

Loading status checks…

87cceeb

Allow for global name import of the library.

Loading status checks…

796d341

Add enums to clean up any symbols from libssh2 and make interacting with them much easier to do. Add additional unit tests for #86

Allow travis to ignore git LFS because the repo is over limit.

Loading status checks…

1402813

Add additional builds on more python 3 versions.

Loading status checks…

edbdc4c

Regenerated Cython C files with 0.29.6

Loading status checks…

e9af1c5

Regenerate Cython using 0.29.14

Loading status checks…

6189741

Add extra host key types to support extra ciphers.

Loading status checks…

db6a4a6

Also add host key types to the ssh2 enums.

Loading status checks…

ea9cc12

Fix `ssh2.enums.HOSTKEY_TYPE` enum.

Loading status checks…

0be263e

Correct issue in `ssh2.sftp_handel.SFTPHandle.readdir*()` which adds EAGAIN items into the generators.

Turn libssh2 source tree into git submodule.

Loading status checks…

28ce1df

Rename library to redlibssh2.

Red-M mentioned this pull request Jun 25, 2020

Add multiple features, bug fixes and update libssh2 to the latest stable. #90

Closed

Red-M changed the title ~~Ssh2 python~~ Add multiple features, bug fixes and update libssh2 to the latest stable. Jun 25, 2020

Red-M mentioned this pull request Jul 25, 2020

Error During Installation #96

Closed

Revert name change for upstream.

Loading status checks…

1b1dca3

pkittenis added the API implementation label Aug 12, 2020

pkittenis reviewed Aug 12, 2020

View changes

Red-M mentioned this pull request Aug 12, 2020

Segmentation fault (core dumped) with userauth_keyboardinteractive #84

Open

pkittenis closed this Aug 13, 2020

Red-M deleted the Red-M:ssh2-python branch Sep 5, 2020

ParallelSSH / ssh2-python

Add multiple features, bug fixes and update libssh2 to the latest stable. #94

Add multiple features, bug fixes and update libssh2 to the latest stable. #94

Red-M commented Jun 25, 2020

llchan commented Jun 29, 2020

Red-M commented Jun 29, 2020

fruch commented Jul 20, 2020

Red-M commented Jul 25, 2020

fruch commented Jul 26, 2020

pkittenis commented Aug 12, 2020

pkittenis commented Aug 12, 2020

pkittenis commented Aug 12, 2020

This comment has been minimized.

This comment has been minimized.

Red-M commented Aug 12, 2020 •

edited

pkittenis commented Aug 13, 2020

Red-M commented Sep 5, 2020 •

edited

ParallelSSH / ssh2-python

Join GitHub today

Add multiple features, bug fixes and update libssh2 to the latest stable. #94

Add multiple features, bug fixes and update libssh2 to the latest stable. #94

Conversation

Red-M commented Jun 25, 2020

Changes

llchan commented Jun 29, 2020

Red-M commented Jun 29, 2020

fruch commented Jul 20, 2020

Red-M commented Jul 25, 2020

fruch commented Jul 26, 2020

pkittenis commented Aug 12, 2020

pkittenis commented Aug 12, 2020

pkittenis commented Aug 12, 2020

This comment has been minimized.

pkittenis Aug 12, 2020

This comment has been minimized.

Red-M Aug 12, 2020 • edited

Red-M commented Aug 12, 2020 • edited

pkittenis commented Aug 13, 2020

Red-M commented Sep 5, 2020 • edited

Red-M Aug 12, 2020 •

edited

Red-M commented Aug 12, 2020 •

edited

Red-M commented Sep 5, 2020 •

edited