★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/17828Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: refactor tests to not rely on timing #17828

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@targos targos

Assignees
No one assigned
Labels
dont-land-on-v10.x dont-land-on-v6.x dont-land-on-v8.x repl
Projects
  
Don't land (ever) in v10.x
Milestone
No milestone
9 participants
@bmeck @Trott @joyeecheung @targos @apapirovski @BridgeAR @MylesBorins @jasnell @nodejs-github-bot
@bmeck
Copy link
Member

bmeck commented Dec 22, 2017

Tests relying on synchronous timing have been migrated to use events.

This is in preparation for more robust testing with the top level await transform. Some minor naming changes were also made to try and make bits more consistent as I was reading them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

repl, test

@nodejs-github-bot nodejs-github-bot added the repl label Dec 22, 2017

@jasnell

jasnell approved these changes Dec 28, 2017
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 28, 2017

@nodejs/testing @addaleax @Fishrock123 @princejwesley
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member

joyeecheung commented Jan 17, 2018

@bmeck this needs a rebase, thanks!
@bmeck
repl: refactor tests to not rely on timing 
Tests relying on synchronous timing have been migrated to use events.
Loading status checks…
01e697e

@bmeck bmeck force-pushed the bmeck:async-repl-tests branch from bbe4925 to 01e697e Jan 17, 2018

@targos

targos approved these changes Jan 20, 2018
View changes

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Jan 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12645/

@maclover7 maclover7 force-pushed the nodejs:master branch from bb5575a to 993b716 Jan 26, 2018

@cjihrig cjihrig force-pushed the nodejs:master branch from 993b716 to 082f952 Jan 26, 2018

@BridgeAR BridgeAR added the author ready label Feb 7, 2018

@apapirovski

This comment has been minimized.

Sign in to view
Copy link
Member

apapirovski commented Feb 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13038/
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Feb 10, 2018

Landed in de848ac 🎉

BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 10, 2018

@bmeck @BridgeAR
repl: refactor tests to not rely on timing 
Tests relying on synchronous timing have been migrated to use events.

PR-URL: nodejs#17828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
de848ac

@BridgeAR BridgeAR closed this Feb 10, 2018

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Feb 11, 2018

Hm, this broke multilines in the repl.

This can easily be verified with:

{

After entering that, it is not possible to type anything anymore.

@bmeck do you think you can get this working soon again? Otherwise I guess the best will be to revert it?

@BridgeAR BridgeAR referenced this pull request Feb 11, 2018

Closed

Revert "repl: refactor tests to not rely on timing" #18715

4 of 4 tasks complete
@bmeck

This comment has been minimized.

Sign in to view
Copy link
Member Author

bmeck commented Feb 11, 2018

@BridgeAR I'll take a look tomorrow and think I can fix it.

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Feb 11, 2018

@cjihrig
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

Refs: nodejs#17828
Refs: nodejs#18715
Verified
This commit was signed with a verified signature.
@cjihrig cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
be5b782

@cjihrig cjihrig referenced this pull request Feb 11, 2018

Merged

test: add multiline repl input regression test #18718

2 of 2 tasks complete

BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 12, 2018

@BridgeAR
Revert "repl: refactor tests to not rely on timing" 
This reverts commit de848ac.

The commit broke multiline repl.

PR-URL: nodejs#18715
Refs: nodejs#17828
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
1fc373b

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Feb 14, 2018

@cjihrig
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

Refs: nodejs#17828
Refs: nodejs#18715
Verified
This commit was signed with a verified signature.
@cjihrig cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
b6ddffd

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Feb 14, 2018

@cjihrig
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: nodejs#18718
Refs: nodejs#17828
Refs: nodejs#18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@cjihrig cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
92c86fd

@MylesBorins MylesBorins added the backport-requested-v9.x label Feb 21, 2018

@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member

MylesBorins commented Feb 21, 2018 •
edited

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

edit: looks like it was reverted setting don't land

@MylesBorins MylesBorins added dont-land-on-v4.x dont-land-on-v6.x dont-land-on-v8.x and removed backport-requested-v9.x labels Feb 21, 2018

@MylesBorins MylesBorins added the dont-land-on-v10.x label Feb 21, 2018

MylesBorins added a commit that referenced this pull request Feb 21, 2018

@cjihrig @MylesBorins
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
e1eccc3

MylesBorins added a commit that referenced this pull request Feb 21, 2018

@cjihrig @MylesBorins
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
d6786d2

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@bmeck @MayaLekova
repl: refactor tests to not rely on timing 
Tests relying on synchronous timing have been migrated to use events.

PR-URL: nodejs#17828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
1a541a1

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@BridgeAR @MayaLekova
Revert "repl: refactor tests to not rely on timing" 
This reverts commit de848ac.

The commit broke multiline repl.

PR-URL: nodejs#18715
Refs: nodejs#17828
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
240bca8

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@cjihrig @MayaLekova
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: nodejs#18718
Refs: nodejs#17828
Refs: nodejs#18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
adf3d20

@targos targos removed the author ready label Jun 8, 2018

MylesBorins added a commit that referenced this pull request Aug 7, 2018

@cjihrig @MylesBorins
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
bc66d4e

MylesBorins added a commit that referenced this pull request Aug 7, 2018

@cjihrig @MylesBorins
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
08ce81f

MylesBorins added a commit that referenced this pull request Aug 9, 2018

@cjihrig @MylesBorins
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
c0c1fc5

rvagg added a commit that referenced this pull request Aug 16, 2018

@cjihrig @rvagg
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
0ed2af4

MylesBorins added a commit that referenced this pull request Aug 16, 2018

@cjihrig @MylesBorins
test: add multiline repl input regression test 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
1169590

@targos targos added this to Don't land (for now) in v10.x Sep 23, 2018

@targos targos moved this from Don't land (for now) to Don't land (ever) in v10.x Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.