test: add multiline repl input regression test #18718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Feb 12, 2018
|
CI https://ci.nodejs.org/job/node-test-pull-request/13119/ @cjihrig please always trigger a CI after creating a PR :-) |
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: nodejs#18718 Refs: nodejs#17828 Refs: nodejs#18715 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
New CI, now that the revert landed: https://ci.nodejs.org/job/node-test-pull-request/13176/ |
MylesBorins
pushed a commit
that referenced
this issue
Feb 21, 2018
Merged
MylesBorins
pushed a commit
that referenced
this issue
Feb 21, 2018
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: nodejs#18718 Refs: nodejs#17828 Refs: nodejs#18715 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this issue
Aug 7, 2018
MylesBorins
pushed a commit
that referenced
this issue
Aug 7, 2018
MylesBorins
pushed a commit
that referenced
this issue
Aug 9, 2018
Merged
MylesBorins
pushed a commit
that referenced
this issue
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit adds a regression test for de848ac, which broke multiline input in the REPL.
This will fail until de848ac is reverted or fixed.
Refs: #17828
Refs: #18715
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test