doc: improve --pending-deprecation documentation
#18433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57dd581
to
4b7187c
Compare
4b7187c
to
f93e3bb
Compare
addaleax
approved these changes
Jan 29, 2018
cjihrig
approved these changes
Jan 29, 2018
jasnell
approved these changes
Jan 29, 2018
lpinca
approved these changes
Jan 29, 2018
danbev
approved these changes
Jan 30, 2018
Trott
approved these changes
Jan 30, 2018
This is described as being a doc-only deprecation subset. Refs: nodejs#18417 PR-URL: nodejs#18433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This adds a mention of `--pending-deprecation` flag effect in the Deprecated APIs document, and explicitly labels deprecations that support it. Refs: nodejs#18417 PR-URL: nodejs#18433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
f93e3bb
to
4efde4d
Compare
|
Landed in e56189e...4efde4d. |
4 tasks
4 tasks
2 tasks
|
Should this be backported to |
MylesBorins
added a commit
that referenced
this issue
Feb 20, 2018
This is described as being a doc-only deprecation subset. Refs: #18417 PR-URL: #18433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
added a commit
that referenced
this issue
Feb 21, 2018
This is described as being a doc-only deprecation subset. Refs: #18417 PR-URL: #18433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
added a commit
that referenced
this issue
Feb 21, 2018
This is described as being a doc-only deprecation subset. Refs: #18417 PR-URL: #18433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
4 tasks
addaleax
added a commit
to addaleax/node
that referenced
this issue
Feb 27, 2018
This adds a mention of `--pending-deprecation` flag effect in the Deprecated APIs document, and explicitly labels deprecations that support it. Refs: nodejs#18417 PR-URL: nodejs#18433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Closed
MayaLekova
added a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
This is described as being a doc-only deprecation subset. Refs: nodejs#18417 PR-URL: nodejs#18433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MayaLekova
added a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
This adds a mention of `--pending-deprecation` flag effect in the Deprecated APIs document, and explicitly labels deprecations that support it. Refs: nodejs#18417 PR-URL: nodejs#18433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This implements steps 1-2 from #18417:
--pending-deprecationis being mentioned in COLLABORATOR_GUIDE.md#deprecations as a subset of doc-deprecation.--pending-deprecationis being mentioned in doc/api/deprecations.md, and the deprecations that support it are explicitly labeled as such (currently, there is only one).Checklist
make lint-mdpassesAffected core subsystem(s)
doc