process: doc-only deprecate non-string env value

process: doc-only deprecate non-string env value
PR-URL: #18990 Refs: #15089 Refs: #18158 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #18990 Refs: #15089 Refs: #18158 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
nodejs · TimothyGu · TimothyGu · TimothyGu · Feb 25, 2018 · TimothyGu
diff --git a/src/node.cc b/src/node.cc
+          "DEP01XX").IsNothing())
+      return;
+    env_nonstring_deprecation_warned = true;
+  }
diff --git a/doc/api/process.md b/doc/api/process.md
@@ -867,7 +871,8 @@ console.log(process.env.foo);
 ```

 Assigning a property on `process.env` will implicitly convert the value
-to a string.
+to a string. **This behavior is deprecated.** Future versions of Node.js will
diff --git a/src/node.cc b/src/node.cc
@@ -2628,6 +2633,17 @@ static void EnvGetter(Local<Name> property,
 static void EnvSetter(Local<Name> property,
                      Local<Value> value,
                      const PropertyCallbackInfo<Value>& info) {
+  if (config_pending_deprecation && !env_nonstring_deprecation_warned &&
+      !value->IsString()) {
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -914,6 +914,16 @@ Type: Runtime

 This was never a documented feature.

+<a id="DEP01XX"></a>
+### DEP01XX: process.env string coercion
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
+<a id="DEP01XX"></a>
+### DEP01XX: process.env string coercion
+
+Type: Documentation-only (supports [`--pending-deprecation`][])
diff --git a/src/node.cc b/src/node.cc
+// Set by EnvSetter when a warning is emitted for non-string assignment to
+// process.env, to prevent the same warning from being emitted multiple times
+// per process.
+bool env_nonstring_deprecation_warned = false;
diff --git a/src/node.cc b/src/node.cc
+      !value->IsString() && !value->IsNumber() && !value->IsBoolean()) {
+    if (ProcessEmitDeprecationWarning(
+          env,
+          "Assigning any value other than a string, number, or boolean value "