★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21145/filesNouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unref in http2 test #21145

Closed
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+0 −6
Diff settings

Always

Just for now

@@ -281,12 +281,6 @@ common.crashOnUnhandledRejection();
});

pipeline(rs, req, common.mustCall((err) => {
// TODO: this is working around an http2 bug
// where the client keeps the event loop going
// (replacing the rs.destroy() with req.end()
// exits it so seems to be a destroy bug there
client.unref();

server.close();
client.close();
}));
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.