Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: remove unref in http2 test #21145
Conversation
apapirovski
added
the
test
label
Jun 5, 2018
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Jun 6, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in 6858ab5 |
apapirovski
closed this
Jun 7, 2018
apapirovski
deleted the
apapirovski:fix-todo-pipeline-test
branch
Jun 7, 2018
apapirovski
added a commit
that referenced
this pull request
Jun 7, 2018
targos
added a commit
that referenced
this pull request
Jun 7, 2018
shisama
added a commit
to shisama/node
that referenced
this pull request
Jun 9, 2018
shisama
added a commit
to shisama/node
that referenced
this pull request
Jun 11, 2018
shisama
added a commit
to shisama/node
that referenced
this pull request
Jun 12, 2018
targos
added a commit
that referenced
this pull request
Jun 13, 2018
shisama
added a commit
to shisama/node
that referenced
this pull request
Jun 17, 2018
This was referenced Jun 20, 2018
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 20, 2018
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
apapirovski commentedJun 5, 2018
The bug referenced in this TODO was fixed and this test no longer requires this code to pass.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes