Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: use Class Method label consistently #21357
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
crypto
doc
labels
Jun 15, 2018
This comment has been minimized.
This comment has been minimized.
vsemozhetbyt
approved these changes
Jun 15, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Node.js Collaborators, please, add |
vsemozhetbyt
added
the
author ready
label
Jun 15, 2018
targos
approved these changes
Jun 16, 2018
Trott
added
the
fast-track
label
Jun 16, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 16, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in 859a8d1 |
Trott
closed this
Jun 16, 2018
targos
added a commit
that referenced
this pull request
Jun 19, 2018
This was referenced Jun 20, 2018
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 20, 2018
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Trott commentedJun 15, 2018
•
edited
The Buffer doc has a helpful "Class Method" label before static methods
on the Buffer class. The only other class in the docs that I can find
with static methods is ECDH in crypto. Add the label to the one static
method on the ECDH class.
Checklist