Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptools: add BigInt to globals #21237
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
fs
tools
labels
Jun 9, 2018
seishun
requested review from
joyeecheung and
devsnek
Jun 9, 2018
devsnek
approved these changes
Jun 9, 2018
ljharb
approved these changes
Jun 9, 2018
Trott
approved these changes
Jun 9, 2018
joyeecheung
approved these changes
Jun 10, 2018
cjihrig
approved these changes
Jun 10, 2018
joyeecheung
added
the
author ready
label
Jun 10, 2018
lpinca
approved these changes
Jun 10, 2018
hiroppy
approved these changes
Jun 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Please |
Trott
added
the
fast-track
label
Jun 10, 2018
ryzokuken
approved these changes
Jun 10, 2018
jasnell
approved these changes
Jun 10, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in bf12384 |
Trott
closed this
Jun 10, 2018
seishun
deleted the
seishun:eslint-bigint
branch
Jun 10, 2018
seishun
referenced this pull request
Jun 11, 2018
Closed
buffer: add {read|write}Big[U]Int64{BE|LE} methods #19691
joyeecheung
referenced this pull request
Jun 11, 2018
Closed
tools: add BigInt64Array and BigUint64Array to globals #21255
targos
added a commit
that referenced
this pull request
Jun 11, 2018
shisama
added a commit
to shisama/node
that referenced
this pull request
Jun 12, 2018
targos
added a commit
that referenced
this pull request
Jun 13, 2018
addaleax
added a commit
that referenced
this pull request
Jun 14, 2018
targos
added a commit
that referenced
this pull request
Jun 14, 2018
shisama
added a commit
to shisama/node
that referenced
this pull request
Jun 17, 2018
This was referenced Jun 20, 2018
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 20, 2018
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
seishun commentedJun 9, 2018
I was going to do it in #19691, but then I noticed that #20220 added several
// eslint-disable-next-line no-undeflines. I talked about it with @ljharb and we agreed that a separate PR makes more sense.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes