Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisessrc: pass along errors from object instantiations #25734
Conversation
addaleax
added some commits
Jan 27, 2019
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
C++
lib / src
labels
Jan 27, 2019
jasnell
approved these changes
Jan 28, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
devsnek
approved these changes
Jan 29, 2019
addaleax
added
the
author ready
label
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 1a37fd6...8e6667f |
addaleax
closed this
Jan 29, 2019
addaleax
deleted the
addaleax:new-instance-1
branch
Jan 29, 2019
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
addaleax
added a commit
that referenced
this pull request
Jan 29, 2019
targos
added a commit
that referenced
this pull request
Jan 29, 2019
targos
added a commit
that referenced
this pull request
Jan 29, 2019
targos
added a commit
that referenced
this pull request
Jan 29, 2019
targos
added a commit
that referenced
this pull request
Jan 29, 2019
targos
added a commit
that referenced
this pull request
Jan 29, 2019
targos
added a commit
that referenced
this pull request
Jan 29, 2019
joyeecheung
reviewed
Jan 29, 2019
| MaybeLocal<Object> Environment::CreateProcessObject( | ||
| const std::vector<std::string>& args, | ||
| const std::vector<std::string>& exec_args) { | ||
| if (*TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED( |
This comment has been minimized.
This comment has been minimized.
joyeecheung
Jan 29, 2019
Member
Why is this part inside CreateProcessObject? (Or rather why is this method named CreateProcessObject?)
This comment has been minimized.
This comment has been minimized.
addaleax
Jan 30, 2019
Author
Member
@joyeecheung Because it’s the part that handles args and exec_args, that’s pretty much all the reason … also, I called it that because that’s what it mainly does, create + set up the process object?
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jan 30, 2019
addaleax
referenced this pull request
Jan 30, 2019
Closed
[v11.x] src: pass along errors from PromiseWrap instantiation #25837
addaleax
added
the
backported-to-v11.x
label
Jan 30, 2019
addaleax
added a commit
that referenced
this pull request
Feb 3, 2019
targos
added this to Backported
in v11.x
Feb 10, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
addaleax commentedJan 27, 2019
Calling
Function::NewInstance()can always fail in the presence of termination exceptions, so we need to check for error conditions when calling it.This PR does not address all of those cases, but at least some of them.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes