★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25837Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.x] src: pass along errors from PromiseWrap instantiation #25837

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@targos targos

Assignees
No one assigned
Labels
C++ v11.x
Projects
  
Closed PRs in v11.x
Milestone
No milestone
3 participants
@addaleax @nodejs-github-bot @targos
@addaleax
Copy link
Member

commented Jan 30, 2019 •
edited

Backport of one commit from #25734, with a minor conflict due to #23443 resolved.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax
src: pass along errors from PromiseWrap instantiation 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
a29a712
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ v11.x labels Jan 30, 2019

@addaleax addaleax force-pushed the addaleax:backport-promise-wrap-newinstance branch from 8cfe09a to a29a712 Jan 30, 2019

@targos

targos approved these changes Jan 31, 2019
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20554/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 3, 2019

Landed in 882902c

addaleax added a commit that referenced this pull request Feb 3, 2019

@addaleax
src: pass along errors from PromiseWrap instantiation 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

PR-URL: #25837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
882902c

@addaleax addaleax closed this Feb 3, 2019

@addaleax addaleax deleted the addaleax:backport-promise-wrap-newinstance branch Feb 3, 2019

@targos targos added this to Closed PRs in v11.x Feb 10, 2019

@targos targos referenced this pull request Feb 14, 2019

Merged

v11.10.0 proposal #26098

This was referenced Feb 15, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.